September 20, 2017, 09:28:40 am
Username:

Password:

Topic: Caravan packer quest feedback enhancement.  (Read 123 times)

Slowhand

  • Posts: 220
  • Go for the eye, Boo! Go for the eyes!
    • View Profile
Caravan packer quest feedback enhancement.
« on: September 10, 2017, 02:06:31 pm »
Add a counter to the Caravan packer quest. Each time you unload a box, there shall be a system/emote feedback on that, so new people know, that they are putting the boxes to the right place (this was an issue for me at Graveyard location, I didn't know where to unload the boxes) and for others as a QoL change.

This is a half assed solution but good enough imo, a better one would be to make a generic quest tracker, maybe some day ;)

Sample code based on Reloaded Season 2 source:

File: quest_caravan_box.fos

Code: [Select]
void _OnDropBox(Item& item, Critter& cr)
...
            GameVar@ var = GetUnicumVar(UVAR_q_box_unload_count, npc.Id, cr.Id);
            if(valid(var))
                var -= 1;
            if(var < 0)
                var = 0;
            //////////// ADD THESE  ///////
            if (var > 0) {
int boxesLeft = var.GetValue();
cr.Say(SAY_NETMSG, "You've unloaded a caravan box. There is only " + boxesLeft + " more to go.");
cr.Say(SAY_EMOTE_ON_HEAD, "*phew*");
    } else {
cr.Say(SAY_NETMSG, "You've unloaded all the caravan boxes, speak to the caravan packer.");
cr.Say(SAY_EMOTE_ON_HEAD, "*stretches back*");
    }
            //////////////////////////////////
            DLog("Box collected!");
            DeleteItem(item);
            return;
        }
...

Note:

In the original code the part from: if(valid(var)) is either faulty, or this check is not needed at all. I did not correct this part, assuming that S3 already did that.


Wipe

  • Posts: 46
  • Random is god
    • View Profile
    • FOdev
Re: Caravan packer quest feedback enhancement.
« Reply #1 on: September 10, 2017, 11:37:57 pm »
As far i know, NPC always yelled at you when you put box in a wrong place.
Games are meant to be created, not played...


Henry

  • Wiki Administrator
  • Global Moderator
  • Posts: 757
  • Gravity is just a theory. Try Density.
    • View Profile
Re: Caravan packer quest feedback enhancement.
« Reply #2 on: September 11, 2017, 12:19:07 am »
Yes and everyone sees it except the person who needs to see it when that person is partially inside the hut. Even when they do see that shout, it's not clear to a newp what that shout is about.

Slowhand

  • Posts: 220
  • Go for the eye, Boo! Go for the eyes!
    • View Profile
Re: Caravan packer quest feedback enhancement.
« Reply #3 on: September 11, 2017, 07:43:09 am »
I never saw the yells myself, usually the caravan master being off my screen.

Also there was a bug in S2, that you can drop the box with Shift+Click and it will not consume it. You can pick it up and drop it again from menu, then it works. So this enhancement is probably not complete.

Programmer

  • Posts: 59
    • View Profile
Re: Caravan packer quest feedback enhancement.
« Reply #4 on: September 12, 2017, 08:33:25 am »
They yell but you can't see it if you have low PE. Console logs would be better solution and NPCs should provide more information where exactly player has to put boxes.

Slowhand

  • Posts: 220
  • Go for the eye, Boo! Go for the eyes!
    • View Profile
Re: Caravan packer quest feedback enhancement.
« Reply #5 on: September 12, 2017, 09:00:23 am »
Has been added to last patch yesterday. Locking topic, can be moved to closed suggestions.